This repository was archived by the owner on Jul 1, 2023. It is now read-only.
build: bump to CMake 3.16, centralise artifacts #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematejska
reviewed
Aug 19, 2020
|
Seems that we didn't document the requirements (I suppose because the intent was that people would be using s-p-m). I don't think that anything should be needed for that, the layout of the tree should be internal to the project. |
Put all the libraries into lib, all the binaries into bin. This bumps up the CMake requirement to 3.16.0 to enable the co-located artifacts. It should make it easier for people to find the artifacts in the build tree.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put all the libraries into lib, all the binaries into bin. This bumps
up the CMake requirement to 3.16.0 to enable the co-located artifacts.
It should make it easier for people to find the artifacts in the build
tree.