This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Remove use of xla::ValidateEinsumNumericDimensions
#1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensorflow/tensorflow@116792d removes the function `xla::ValidateEinsumNumericDimensions` because all expressible op configurations are valid, and thus this function effectively always returns `true`. This change updates the S4TF usage to remove the function call, and always return true.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tensorflow/tensorflow@116792d
removes the function
xla::ValidateEinsumNumericDimensionsbecause allexpressible op configurations are valid, and thus this function effectively
always returns
true. This change updates the S4TF usage to remove thefunction call, and always return true.