Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Add average, multiply and stack modes for BiRNNs #1101

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

kongzii
Copy link
Contributor

@kongzii kongzii commented Oct 8, 2020

This will close #1098, more specifically, it adds rest of merge modes available in Keras in bidirectional recurrent layers.

  • ave as average
  • mul as multiply
  • none as stack

If you can think of better names I will happily edit them :) Thanks for reviews!

Copy link
Contributor

@xihui-wu xihui-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xihui-wu xihui-wu merged commit 7465fdb into tensorflow:master Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remaining Bidirectional RNN merge modes
3 participants