Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Adding Upsampling 3D layer and tests for upsampling layers #112

Merged
merged 11 commits into from
Apr 25, 2019

Conversation

Shashi456
Copy link
Contributor

No description provided.

Copy link
Member

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test to Tests/DeepLearningTests/LayerTests.swift?

@Shashi456
Copy link
Contributor Author

@dan-zheng should i add tests for the other upsampling layers in this PR?

@dan-zheng
Copy link
Member

@dan-zheng should i add tests for the other upsampling layers in this PR?

Yes please, that would be splendid!

@Shashi456 Shashi456 changed the title Adding Upsampling 3D layer Adding Upsampling 3D layer and tests for upsampling layers Apr 22, 2019
@dan-zheng dan-zheng requested a review from rxwei April 22, 2019 07:37
Copy link
Member

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! To ensure all our APIs are consistently formatted, could you make sure all lines are fit within 100 columns?

Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Shashi456
Copy link
Contributor Author

@rxwei I think this can be merged.

@rxwei rxwei merged commit 1dc4afb into tensorflow:master Apr 25, 2019
@rxwei
Copy link
Contributor

rxwei commented Apr 25, 2019

Thanks!

@Shashi456 Shashi456 deleted the ups branch April 25, 2019 11:23
Shashi456 added a commit to Shashi456/swift-apis that referenced this pull request Apr 29, 2019
@dan-zheng
Copy link
Member

Note: the test for UpSampling3D is broken and testUpSampling3D has been disabled.
Please see TF-525 for more details.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants