-
Notifications
You must be signed in to change notification settings - Fork 137
Adding Upsampling 3D layer and tests for upsampling layers #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a test to Tests/DeepLearningTests/LayerTests.swift
?
Co-Authored-By: Shashi456 <[email protected]>
@dan-zheng should i add tests for the other upsampling layers in this PR? |
Yes please, that would be splendid! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! To ensure all our APIs are consistently formatted, could you make sure all lines are fit within 100 columns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Co-Authored-By: Shashi456 <[email protected]>
Co-Authored-By: Shashi456 <[email protected]>
Co-Authored-By: Shashi456 <[email protected]>
@rxwei I think this can be merged. |
Thanks! |
Note: the test for |
No description provided.