This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Improve API documentation. #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Standardize documentation for `func call(_:)`. - Minor edits to RNN docs.
Shashi456
reviewed
Apr 24, 2019
| @@ -1329,7 +1307,7 @@ public struct SimpleRNNCell<Scalar: TensorFlowFloatingPoint>: RNNCell, VectorNum | |||
| } | |||
| } | |||
|
|
|||
| /// An LSTM Cell. | |||
| /// An LSTM cell. | |||
There was a problem hiding this comment.
Shouldn't this be A LSTM cell ?
There was a problem hiding this comment.
Since people tend to pronounce the acronym directly, the pronunciation starts with a vowel, so "An" would be most appropriate.
Shashi456
pushed a commit
to Shashi456/swift-apis
that referenced
this pull request
Apr 29, 2019
- Standardize documentation for `func call(_:)`. - Minor edits to RNN docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
func call(_:).