Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

[TF] Removed 'HackyTensorflowMigrationSupport' from apple/swift. #139

Merged
merged 1 commit into from
May 30, 2019

Conversation

eaplatanios
Copy link
Contributor

@rxwei @pschuh Removed HackyTensorflowMigrationSupport.swift from apple/swift.

Friend PR: swiftlang/swift#25147.

@rxwei
Copy link
Contributor

rxwei commented May 30, 2019

I'm gonna merge this first, so that you can update the checkout hash in apple/swift in order for that to run CI.

@eaplatanios
Copy link
Contributor Author

Sounds good.

@rxwei rxwei merged commit 835d143 into tensorflow:master May 30, 2019
rxwei pushed a commit to swiftlang/swift that referenced this pull request May 30, 2019
Removed `HackyTensorflowMigrationSupport.swift`.

Friend PR: tensorflow/swift-apis#139.
rxwei added a commit to rxwei/swift that referenced this pull request Jun 4, 2019
`TensorArrayProtocol` and `TensorGroup` have been [moved](tensorflow/swift-apis#139) to [tensorflow/swift-apis](https://github.com/tensorflow/swift-apis), and their derived conformances tests have been [copied](tensorflow/swift-apis#158) there as well. [tensorflow/swift-apis#165](tensorflow/swift-apis#165) changed the protocol requirements which made `TensorGroup` conformances no longer entirely derivable, but the derived conformances tests in this repo have not been updated, and it's blocking us from updating the checkout hash for tensorflow/swift-apis.

This PR removes `TensorGroup` derived conformance tests from apple/swift. We expect future changes to `TensorGroup` derived conformances to thoroughly test against tensorflow/swift-apis.
rxwei added a commit to swiftlang/swift that referenced this pull request Jun 4, 2019
`TensorArrayProtocol` and `TensorGroup` have been [moved](tensorflow/swift-apis#139) to [tensorflow/swift-apis](https://github.com/tensorflow/swift-apis), and their derived conformances tests have been [copied](tensorflow/swift-apis#158) there as well. [tensorflow/swift-apis#165](tensorflow/swift-apis#165) changed the protocol requirements which made `TensorGroup` conformances no longer entirely derivable, but the derived conformances tests in this repo have not been updated, and it's blocking us from updating the checkout hash for tensorflow/swift-apis.

This PR removes `TensorGroup` derived conformance tests from apple/swift. We expect future changes to `TensorGroup` derived conformances to thoroughly test against tensorflow/swift-apis.

Unblocks #25235.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants