Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Added support for the 'sign' op and its VJP. #144

Merged
merged 13 commits into from
May 31, 2019
Merged

Conversation

eaplatanios
Copy link
Contributor

No description provided.

@rxwei
Copy link
Contributor

rxwei commented May 30, 2019

Could you add a test for each of these operators?

@eaplatanios
Copy link
Contributor Author

I can do that yes. I just noticed that there were no tests for other wrappers of TF ops. It would be nice if we added a little helper that executes XCTAssertEqual(_:_:accuracy:) element-wise on tensors. I could look into that later tonight.

@rxwei
Copy link
Contributor

rxwei commented May 30, 2019

Yeah, other ops are mostly not tested. The migration made it so much easier to write tests now.

@eaplatanios
Copy link
Contributor Author

I merged the matmul PR here (so I can get the test helpers) and added a test for sign. The diff once the matmul PR is merged should be very small. I'll do the same for the other new ops.

@eaplatanios
Copy link
Contributor Author

@rxwei This has been updated with the merged PR changes and is ready to be tested. #142 is also ready to be tested.

@rxwei
Copy link
Contributor

rxwei commented May 31, 2019

Kokoro seems back online. Thanks @bgogul for fixing it!

@rxwei
Copy link
Contributor

rxwei commented May 31, 2019

Kokoro seems back online. Thanks @bgogul for fixing it!

@bgogul said he didn't do anything. Not sure what happened, Kokoro :)

@eaplatanios
Copy link
Contributor Author

Haha yeah CI servers do that sometimes and it's so frustrating when they just don't trigger :)

@eaplatanios
Copy link
Contributor Author

Hmm I'm not sure what's wrong in Kokoro but earlier it was showing that same log while tests were passing locally.

@rxwei
Copy link
Contributor

rxwei commented May 31, 2019

All tests pass locally on my machine. Merging.

@rxwei rxwei merged commit 349ae47 into tensorflow:master May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants