This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add derivative for 'padded(forSizes:with:)'. #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix: #179 |
eaplatanios
suggested changes
Jun 9, 2019
| @@ -491,6 +502,7 @@ final class BasicOperatorTests: XCTestCase { | |||
| ("testUnbroadcast1", testUnbroadcast1), | |||
| ("testUnbroadcast2", testUnbroadcast2), | |||
| ("testSliceUpdate", testSliceUpdate), | |||
| ("testVJPPadded", testVJPPadded), | |||
There was a problem hiding this comment.
Could you add a test for padded too as part of this PR since it’s missing?
And also maybe move them both right after testGathering in an attempt to keep the order consistent between the test files and the source files?
| @@ -674,6 +674,7 @@ extension Tensor where Scalar: TensorFlowFloatingPoint { | |||
| public extension Tensor where Scalar: Numeric { | |||
| /// Returns a padded tensor according to the specified padding sizes. | |||
| @inlinable | |||
| @differentiable(wrt:self, vjp: _vjpPadded(forSizes:with:) where Scalar: TensorFlowFloatingPoint) | |||
| begin: Tensor<Int32>([0, 0]), | ||
| size: Tensor<Int32>(stacking: [rank, Tensor<Int32>(1)])) | ||
| let begin = Raw.reshape(padBefore, shape: Tensor<Int32>([-1])) | ||
| return Raw.slice(v,begin: begin,size: shape) |
There was a problem hiding this comment.
begin,size -> begin, size
| return (result, { [rank = rankTensor, shape = shapeTensor] v in | ||
| let paddings = Tensor<Int32>( | ||
| shape: [sizes.count, 2], | ||
| scalars: sizes.flatMap {[Int32($0.before), Int32($0.after)] }) |
| @@ -466,6 +466,17 @@ final class BasicOperatorTests: XCTestCase { | |||
| XCTAssertEqual(target, Tensor(repeating: 1, shape: [2, 3, 4])) | |||
| } | |||
|
|
|||
| func testVJPPadded() { | |||
| // 1 -> 2 x 3 x 4 | |||
| let x = Tensor<Float>(ones:[3,2]) | |||
There was a problem hiding this comment.
In the test function code, could you please add spaces after all the argument labels?
And also between the literals in arrays and tuples?
|
@eaplatanios All the requested changes are done. |
rxwei
reviewed
Jun 10, 2019
Co-Authored-By: Richard Wei <[email protected]>
Co-Authored-By: Richard Wei <[email protected]>
Co-Authored-By: Richard Wei <[email protected]>
Co-Authored-By: Richard Wei <[email protected]>
Co-Authored-By: Richard Wei <[email protected]>
Co-Authored-By: Richard Wei <[email protected]>
Co-Authored-By: Richard Wei <[email protected]>
rxwei
changed the title
dan12411
pushed a commit
to dan12411/swift-apis
that referenced
this pull request
Jun 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #179.