This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add liveness tracking to LazyTensor #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
reviewed
Jun 10, 2019
| @@ -16,6 +16,18 @@ import XCTest | |||
| @testable import TensorFlow | |||
| import CTensorFlow | |||
|
|
|||
| struct LazyTensorOperationRef : Equatable, Hashable { | |||
There was a problem hiding this comment.
Hmm, why not just extend LazyTensorOperation to Equatable and Hashable? The wrapper doesn't seem to buy you anything.
There was a problem hiding this comment.
Actually, I want that as well for some caching in lazy tensor implementation. However, not all properties of LazyTensorOperation will automatically conform to Equatable and Hashable. e.g., Attribute has some associated types that don't conform.
I will send out a separate PR with all the needed changes.
|
@rxwei Thanks for the review. I addressed your comments. PTAL. |
rxwei
approved these changes
Jun 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks list of
LazyTensorOperationinstances held inLazyTensorinstances. This is required to perform batch materialization of all live tensors during lazy evaluation.