Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Make some LazyTensor properties @usableFromInline #191

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Conversation

bgogul
Copy link
Contributor

@bgogul bgogul commented Jun 10, 2019

No description provided.

@bgogul bgogul requested a review from rxwei June 10, 2019 22:06
Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason more things need to be @usableFromInline? Public linkage was only necessary for GPE, transitively required for code serialization. Instead of adding more public symbols, I think we should clean up the @inlinable and @usableFromInline's from our library.

@bgogul
Copy link
Contributor Author

bgogul commented Jun 10, 2019

Is there a reason more things need to be @usableFromInline? Public linkage was only necessary for GPE, transitively required for code serialization. Instead of adding more public symbols, I think we should clean up the @inlinable and @usableFromInline's from our library.

Unfortunately, this is a consequence of already having @inlinable in some parts of the TensorFlow library. In a downstream PR, I am using these in a function in Runtime.swift that is marked as @inlinable. We have https://bugs.swift.org/browse/TF-513 to clean up inlining-related annotations.

@bgogul bgogul merged commit 5a3485d into master Jun 10, 2019
@bgogul bgogul deleted the bgogul-patch-1 branch June 10, 2019 23:00
dan12411 pushed a commit to dan12411/swift-apis that referenced this pull request Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants