This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Conform Tensor to ElementaryFunctions.
#200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also semi-blocked on swiftlang/swift#25316. |
dan-zheng
force-pushed
the
elementary-functions
branch
2 times, most recently
from
b882d0e to
4612b60
Compare
Conditionally conform `Tensor` to `ElementaryFunctions` where `Scalar: TensorFlowFloatingPoint`.
dan-zheng
force-pushed
the
elementary-functions
branch
from
4612b60 to
51fe3e9
Compare
dan-zheng
reviewed
Jun 14, 2019
|
Ready for review. cc @rxwei |
dan-zheng
reviewed
Jun 14, 2019
| // version for `FloatingPoint`. | ||
| // This is a manual definition. | ||
| @inlinable | ||
| func pow<T: BinaryFloatingPoint>(_ x: T, _ y: T) -> T { |
There was a problem hiding this comment.
This function is no longer necessary.
|
Will look soon! |
rxwei
commented
Jun 14, 2019
dan-zheng
force-pushed
the
elementary-functions
branch
from
0c1ff41 to
8cf1a66
Compare
dan12411
pushed a commit
to dan12411/swift-apis
that referenced
this pull request
Jun 15, 2019
Conditionally conform `Tensor` to `ElementaryFunctions` where `Scalar: TensorFlowFloatingPoint`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.