This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Adding kullback Leibler Divergence #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeta
approved these changes
Jun 13, 2019
rxwei
approved these changes
Jun 13, 2019
eaplatanios
reviewed
Jun 13, 2019
| @@ -98,6 +98,18 @@ public func poissonLoss<Scalar: TensorFlowFloatingPoint>( | |||
| return (predicted - expected * log(predicted)).mean() | |||
| } | |||
|
|
|||
| /// Returns the Kullback-Leibler divergence between predictions and expectations. | |||
There was a problem hiding this comment.
You should probably say "between expectations and predictions" and also add the actual equation because KL divergence is not symmetric and so this may lead people to thinking the opposite of what's intended.
There was a problem hiding this comment.
@Shashi456 could you possibly make a new PR addressing this?
There was a problem hiding this comment.
On it. I'll have it up in a few hours.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build and test passes locally.
Reference #127