This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Adding L1 & L2 Losses and respective tests #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeta
approved these changes
Jun 13, 2019
rxwei
approved these changes
Jun 13, 2019
rxwei
reviewed
Jun 13, 2019
Co-Authored-By: Richard Wei <[email protected]>
rxwei
reviewed
Jun 13, 2019
|
Also @rxwei when is swift-apis v0.4 slotted? o.O I have no idea. |
|
We've decided to delay v0.4 until a couple more fixes and library cleanups. |
rxwei
approved these changes
Jun 13, 2019
|
@rxwei could you trigger a build on this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds and passes locally.
Reference #127
Sorry for the onslaught of additions today, hope it's alright :P.