-
Notifications
You must be signed in to change notification settings - Fork 137
Port over tensor_autodiff_runtime.swift
tests.
#235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bartchr808. Can you name the tests appropriately?
@bgogul quick ping for a re-review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just address Richard's comments?
func foo(tensor: Tensor<Float>, shape: Tensor<Int32>) -> Tensor<Float> { | ||
tensor.unbroadcasted(toShape: shape) | ||
} | ||
var inputTensor: Tensor<Float> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for the initialization to be an a different line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can initialize it to the one needed for the first subtest.
- Port over tensor_autodiff_runtime.swift tests from apple/swift PR 24899.
This PR ports over the tests that were located here in
apple/swift
before the refactor. Not all of them were ported over, as seen in the PR here, and this PR only adds the ones inTensorFlowRuntime/tensor_autodiff_runtime.swift
and also the ones I was going to add for testingbroadcast
/unbroadcast
in this PR.