This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Fix implementation of root(Tensor, Int).
#238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test failures regarding `root(Tensor, Int)` erroneous returning NaNs. Inspired by the implementation of `root` for `FloatingPoint` types in swift/stdlib/public/core/MathFunctions.swift.gyb.
|
For reference, here are the previous failures: With this patch, tests pass: |
|
Merging to unblock progress, happy to address comments later. |
dan12411
pushed a commit
to dan12411/swift-apis
that referenced
this pull request
Jun 15, 2019
Fix test failures regarding `root(Tensor, Int)` erroneous returning NaNs. Inspired by the implementation of `root` for `FloatingPoint` types in swift/stdlib/public/core/MathFunctions.swift.gyb.
|
@dan-zheng Sorry to comment on this so late, but I believe this may be unexpected behavior to some users. Mathematically, this is only correct for odd roots. Even roots should not be defined for negative values. This should at least be mentioned in the documentation, if not modified. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test failures regarding
root(Tensor, Int)erroneous returning NaNs.Inspired by the implementation of
rootforFloatingPointtypes inswift/stdlib/public/core/MathFunctions.swift.gyb.