Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Provide proper documentation for non-mutating functions #261

Merged
merged 3 commits into from
Jun 19, 2019

Conversation

jon-tow
Copy link
Contributor

@jon-tow jon-tow commented Jun 19, 2019

A quick clean up to help with #160 to avoid wasting time.

@Shashi456
Copy link
Contributor

Shashi456 commented Jun 19, 2019

I think this still needs to be addressed.
Also there are a variety of functions at large which need some sorta explanation and clean-up in a similar fashion.

@jon-tow
Copy link
Contributor Author

jon-tow commented Jun 19, 2019

Ah sorry, I thought I'd save you some time with this. Should I close this?

@Shashi456
Copy link
Contributor

@jon-tow no, this is good work. We can discuss some things about the variety of functions in Math.swift, this does save time.

Co-Authored-By: Pawan Sasanka Ammanamanchi <[email protected]>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jon-tow
Copy link
Contributor Author

jon-tow commented Jun 19, 2019

I confirm the co-authoring! (Not sure how to handle the googlebot co-authoring check.)

@rxwei rxwei merged commit 5fa5d5c into tensorflow:master Jun 19, 2019
@jon-tow jon-tow deleted the doc/non-mutating-api branch June 20, 2019 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants