-
Notifications
You must be signed in to change notification settings - Fork 137
Provide proper documentation for non-mutating functions #261
Conversation
I think this still needs to be addressed. |
Ah sorry, I thought I'd save you some time with this. Should I close this? |
@jon-tow no, this is good work. We can discuss some things about the variety of functions in Math.swift, this does save time. |
Co-Authored-By: Pawan Sasanka Ammanamanchi <[email protected]>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I confirm the co-authoring! (Not sure how to handle the googlebot co-authoring check.) |
A quick clean up to help with #160 to avoid wasting time.