-
Notifications
You must be signed in to change notification settings - Fork 137
Tensor documentation update. (#TF-448) #263
Tensor documentation update. (#TF-448) #263
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
I signed it! |
1 similar comment
I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I left some comments on the wording as well as the formatting style which is different from the apple/swift repo.
Sources/TensorFlow/Core/Tensor.swift
Outdated
@@ -23,8 +23,12 @@ public protocol AnyTensor { | |||
var _tensorFlowDataType: TensorDataType { get } | |||
} | |||
|
|||
/// `Tensor` is a multi-dimensional array used for computation. It is a wrapper around a | |||
/// `TensorHandle`. | |||
/// A multidimensional array of elements that is a generalization of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The column limit in this repo is 100. Could you please make these comments fit in 100 columns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I have made sure that these comments fit in 100 columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although they do fit within 100 columns, I don't believe they fit to size yet. Could you expand each line so that it fits to size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested, each line is expanded so that it fits to size.
b0932a1
to
9aa2a66
Compare
I signed it! |
I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@googlebot rescan |
Updated documentation for Tensor in Tensor.swift file
Resolves TF-448.