Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Tensor documentation update. (#TF-448) #263

Merged
merged 3 commits into from
Jun 20, 2019

Conversation

ksasi
Copy link
Contributor

@ksasi ksasi commented Jun 19, 2019

Updated documentation for Tensor in Tensor.swift file

Resolves TF-448.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ksasi
Copy link
Contributor Author

ksasi commented Jun 19, 2019

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ksasi
Copy link
Contributor Author

ksasi commented Jun 19, 2019

I signed it!

1 similar comment
@ksasi
Copy link
Contributor Author

ksasi commented Jun 19, 2019

I signed it!

Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I left some comments on the wording as well as the formatting style which is different from the apple/swift repo.

@@ -23,8 +23,12 @@ public protocol AnyTensor {
var _tensorFlowDataType: TensorDataType { get }
}

/// `Tensor` is a multi-dimensional array used for computation. It is a wrapper around a
/// `TensorHandle`.
/// A multidimensional array of elements that is a generalization of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column limit in this repo is 100. Could you please make these comments fit in 100 columns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I have made sure that these comments fit in 100 columns.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although they do fit within 100 columns, I don't believe they fit to size yet. Could you expand each line so that it fits to size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested, each line is expanded so that it fits to size.

@ksasi ksasi force-pushed the Improve-Tensor-type-documentation branch from b0932a1 to 9aa2a66 Compare June 19, 2019 19:27
@ksasi
Copy link
Contributor Author

ksasi commented Jun 19, 2019

I signed it!

@ksasi
Copy link
Contributor Author

ksasi commented Jun 19, 2019

I signed it!

Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ksasi
Copy link
Contributor Author

ksasi commented Jun 20, 2019

@googlebot rescan

@rxwei rxwei merged commit 5957d9e into tensorflow:master Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants