Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Add support for gelu #268

Merged
merged 2 commits into from
Jun 21, 2019
Merged

Add support for gelu #268

merged 2 commits into from
Jun 21, 2019

Conversation

jon-tow
Copy link
Contributor

@jon-tow jon-tow commented Jun 21, 2019

Given its usage in recent state of the art NLP models (XLNet, GPT-2, BERT, etc.), gelu seems to be a useful activation for future users to reach for.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@jon-tow jon-tow force-pushed the math/gelu branch 2 times, most recently from 7993ba0 to 904363d Compare June 21, 2019 07:31
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@saeta saeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saeta saeta merged commit db42eb9 into tensorflow:master Jun 21, 2019
@jon-tow jon-tow deleted the math/gelu branch June 21, 2019 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants