Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Fix doc of mutating function in Math.swift. #270

Merged
merged 1 commit into from
Jun 22, 2019

Conversation

naru-jpn
Copy link
Contributor

Reference #160

Fix doc of mutating function with no return value.

@Shashi456
Copy link
Contributor

You seem to be reverting the changes made in #183.

@naru-jpn
Copy link
Contributor Author

naru-jpn commented Jun 21, 2019

Doc says "This function returns value" but actually function returns no value and store value in left side variable.
#160 is an issue about non-mutating function.
I don't want to revert some PR... But I think that I should improve doc for developers.

Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eaplatanios eaplatanios merged commit f0d3a16 into tensorflow:master Jun 22, 2019
@naru-jpn naru-jpn deleted the fix_mutating_func_doc branch June 23, 2019 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants