This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Fixed the handling of integer data types in the raw ops generation script. #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass locally and currently running on the CI. |
rxwei
reviewed
Jun 21, 2019
rxwei
approved these changes
Jun 21, 2019
|
@rxwei for this and future PRs, if approved by at least one reviewer and the CI test pass, should I go ahead and merge? |
|
Yes, please! Thank you for the help maintaining the library! |
|
Thanks for making it easier to do so! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #272.