This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Putting LazyTensor components together #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
reviewed
Jun 25, 2019
| inputs = inputs.map { maybeMaterialized(input: $0) } | ||
| } | ||
|
|
||
| private static func materializeLiveTensors(_ lazyOp: LazyTensorOperation) { |
There was a problem hiding this comment.
Since this takes a Self, why not define it as an instance method?
| func maybeMaterialized(lazyTensor: LazyTensor) -> LazyTensor { | ||
| let handle = lazyTensor.handle | ||
| if case let LazyTensor.Handle.symbolic(lazyOp, index, _) = handle { | ||
| if let outputs = lazyOp.outputs { |
There was a problem hiding this comment.
if accepts multiple conditions and optional binding clauses separated by a comma.
Suggested change
| if let outputs = lazyOp.outputs { | |
| let outputs = lazyOp.outputs { |
| private func maybeMaterializeInputs() { | ||
| func maybeMaterialized(lazyTensor: LazyTensor) -> LazyTensor { | ||
| let handle = lazyTensor.handle | ||
| if case let LazyTensor.Handle.symbolic(lazyOp, index, _) = handle { |
There was a problem hiding this comment.
Suggested change
| if case let LazyTensor.Handle.symbolic(lazyOp, index, _) = handle { | |
| if case let LazyTensor.Handle.symbolic(lazyOp, index, _) = handle, |
| func maybeMaterialized(input: Input) -> Input { | ||
| switch input { | ||
| case .single(let h): | ||
| return Input.single(maybeMaterialized(lazyTensor: h)) |
There was a problem hiding this comment.
Suggested change
| return Input.single(maybeMaterialized(lazyTensor: h)) | |
| return .single(maybeMaterialized(lazyTensor: h)) |
| case .single(let h): | ||
| return Input.single(maybeMaterialized(lazyTensor: h)) | ||
| case .list(let elements): | ||
| return Input.list(elements.map { maybeMaterialized(lazyTensor: $0) }) |
There was a problem hiding this comment.
Suggested change
| return Input.list(elements.map { maybeMaterialized(lazyTensor: $0) }) | |
| return .list(elements.map { maybeMaterialized(lazyTensor: $0) }) |
| return lazyTensor | ||
| } | ||
|
|
||
| func maybeMaterialized(input: Input) -> Input { |
There was a problem hiding this comment.
Could you elaborate on what "maybe" stands for here?
There was a problem hiding this comment.
Added a brief comment to the function. Basically, if any symbolic value in the input has been materialized, the input is rewritten by replacing the symbolic value with the corresponding concrete value.
There was a problem hiding this comment.
How about materializedAsNeeded(_:)?
bgogul
force-pushed
the
materialization
branch
3 times, most recently
from
0e5a963 to
43c7e1a
Compare
Extracted traces are evaluated and used for materializing lazy tensors.
rxwei
approved these changes
Jun 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use extracted traces to evaluate and materializing lazy tensors.