Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Add precondition message for Tensor initialization #301

Merged
merged 8 commits into from
Jun 27, 2019

Conversation

jon-tow
Copy link
Contributor

@jon-tow jon-tow commented Jun 27, 2019

Adds precondition messages for failing tensor initializer, init(shape:scalars:), and failing scalarized, scalarized().

Copy link
Contributor

@saeta saeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally awesome @jon-tow ! Thank you very much for making this change. I just had one small suggestion for how to make this even better. WDYT?

Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jon-tow!

Copy link
Contributor

@saeta saeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful. Thank you so much for this. I think it's going to be a big usability win!

@saeta saeta merged commit ec83fa7 into tensorflow:master Jun 27, 2019
@jon-tow jon-tow deleted the tensor/preconditions branch June 27, 2019 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants