This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Added support for negative 'axis' argument values to 'Tensor.unstacked(alongAxis:)'. #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
reviewed
Jul 11, 2019
|
@dan-zheng I added a test as you requested, but it currently causes a compiler crash that is irrelevant to this PR. I filed TF-653 to track it. |
rxwei
approved these changes
Jul 13, 2019
|
SGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix the gradients of
Tensor.init(stacking:alongAxis:)are wrong whenaxisis negative. It also makes it consistent with other functions that take in axis arguments.