This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Added a couple missing 'Tensor.moments' functions. #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
Jul 14, 2019
| @@ -2317,12 +2317,24 @@ public extension Tensor where Scalar: TensorFlowFloatingPoint { | |||
| /// dimensions are removed. | |||
There was a problem hiding this comment.
Add a precondition which states that axes.rank must be 0.
There was a problem hiding this comment.
It has to be rank 1, but I didn't add it because it would cause lazy tensor materialization. The same is true for all reduction ops and we don't use any preconditions there.
There was a problem hiding this comment.
Oh sorry I meant rank 1. Precondition should be added in comments at least.
There was a problem hiding this comment.
Good point. I added it in the documentation strings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.