Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Add @differentiable support to pow(_:_:) and root(_:_:) #366

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Add @differentiable support to pow(_:_:) and root(_:_:) #366

merged 1 commit into from
Jul 15, 2019

Conversation

jon-tow
Copy link
Contributor

@jon-tow jon-tow commented Jul 15, 2019

Addresses #365.

@saeta saeta merged commit cf9ee4f into tensorflow:master Jul 15, 2019
rxwei
rxwei approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also add these attributes to pow(_:_:) and root(_:_:) defined under the ElementaryFunction conformance?

@jon-tow
Copy link
Contributor Author

jon-tow commented Jul 15, 2019

@rxwei Sure thing! I'll open a PR for it in just a few.

@jon-tow jon-tow deleted the math/differentiables branch July 15, 2019 21:25
@Shashi456 Shashi456 mentioned this pull request Jul 16, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rxwei rxwei rxwei approved these changes

@eaplatanios eaplatanios eaplatanios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jon-tow @rxwei @eaplatanios @saeta @kokoro-team