This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Adds a mechanism to extract traces explicitly using LazyTensor. #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgogul
force-pushed
the
trace_with_lazy_tensor
branch
3 times, most recently
from
823d415 to
ccdbbee
Compare
Added a flag to not promote constants.
bgogul
force-pushed
the
trace_with_lazy_tensor
branch
from
ccdbbee to
f4d32f7
Compare
bgogul
force-pushed
the
trace_with_lazy_tensor
branch
from
baa8cd4 to
277c172
Compare
bgogul
changed the title
rxwei
reviewed
Jul 23, 2019
|
@rxwei Thanks for the review. I addressed your comments. PTAL. |
rxwei
approved these changes
Jul 23, 2019
rxwei
reviewed
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
LazyTensorto perform extract traces explicitly. This mechanism will be used to replace the existing tracing mechanism inRuntime.swift.