This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Rewrite tracing utilities in terms of LazyTensor. #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgogul
changed the title
rxwei
reviewed
Jul 24, 2019
| @@ -934,65 +934,33 @@ public func _tffunc<State: _TensorArrayProtocolEnhanced, Data: TensorGroup>( | |||
| } | |||
| } | |||
|
|
|||
| internal func _trace<In: TensorGroup, Out: TensorGroup>(_ fn: (In) -> Out) -> TFFunction { | |||
| let useLazyTensor = _RuntimeConfig.useLazyTensor | |||
There was a problem hiding this comment.
Ah.. you are right. Hold the review on this.
There was a problem hiding this comment.
This should be resolved now.
bgogul
changed the title
bgogul
changed the title
bgogul
changed the title
rxwei
approved these changes
Jul 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements
_tffuncand_graphinRuntime.swiftusing the explicit tracing mechanism in LazyTensor.