Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Move the computation of shape and rank to TFETensorHandle. #401

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

bgogul
Copy link
Contributor

@bgogul bgogul commented Jul 30, 2019

This is a necessary step to incorporate shape inference into LazyTensorHandle.

This is a necessary step to incorporate shape inference into `LazyTensorHandle`.
@bgogul bgogul requested review from eaplatanios and dan-zheng July 30, 2019 05:50
Copy link
Member

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bgogul
Copy link
Contributor Author

bgogul commented Jul 30, 2019

Thanks for the review, @dan-zheng

@bgogul bgogul merged commit 728a2d6 into tensorflow:master Jul 30, 2019
@bgogul bgogul deleted the add_shape_to_handle branch July 30, 2019 06:04
@eaplatanios
Copy link
Contributor

@bgogul That's great! Are we currently using a version of TF that supports the C API for shapes or has that not been merged yet?

@bgogul
Copy link
Contributor Author

bgogul commented Jul 30, 2019

@bgogul That's great! Are we currently using a version of TF that supports the C API for shapes or has that not been merged yet?

We have the shape inference API now. I just merged it in this morning. Unfortunately, swift-apis does not build with the swift compiler at head. :( @dan-zheng is looking into it.

@eaplatanios
Copy link
Contributor

That's great! Thanks for the update @bgogul! :) It would be nice to get some benchmarking suite up at some point to see how large an impact changes like this one combined with lazy tensor make.

@bgogul
Copy link
Contributor Author

bgogul commented Jul 30, 2019

That's great! Thanks for the update @bgogul! :) It would be nice to get some benchmarking suite up at some point to see how large an impact changes like this one combined with lazy tensor make.

Certainly! We have been having performance benchmarking on our radar for a while (https://bugs.swift.org/browse/TF-663). If you have any suggestions, please do share on the ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants