Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Disable failing BasicOperatortests.testVJPConcatentation. #403

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

bgogul
Copy link
Contributor

@bgogul bgogul commented Jul 31, 2019

@bgogul bgogul requested a review from dan-zheng July 31, 2019 17:57
@bgogul bgogul merged commit 36938cf into tensorflow:master Jul 31, 2019
@bgogul bgogul deleted the disable_vjp_test branch July 31, 2019 18:10
@eaplatanios
Copy link
Contributor

@bgogul @dan-zheng I don't think it's a good idea to remove this test. It's quite simple and should be working. If the new toolchain results in incompatible shapes for some reason, we should probably find out why that happens. This kind of operation is common across many models and so existing code may break if this test fails.

@dan-zheng
Copy link
Member

@bgogul @dan-zheng I don't think it's a good idea to remove this test. It's quite simple and should be working. If the new toolchain results in incompatible shapes for some reason, we should probably find out why that happens. This kind of operation is common across many models and so existing code may break if this test fails.

I'm investigating the failure now. I haven't narrowed down the cause yet; once I do, I'll revert the apple/swift PR that introduced the breakage if an immediate fix isn't obvious.

@eaplatanios
Copy link
Contributor

That's great. Thanks Dan!

@dan-zheng
Copy link
Member

Fixed derivatives of Tensor.concatenated(with:) and Tensor.++ in swiftlang/swift#26448.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants