This repository was archived by the owner on Jul 1, 2023. It is now read-only.
added test for LSTMCell #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dhasl002
commented
Aug 4, 2019
dhasl002
commented
- added unit test for LSTM cell, this feature was previously untested
rxwei
reviewed
Aug 5, 2019
| let (outputs, _) = rnn.valueWithPullback(at: inputs) { rnn, inputs in | ||
| return rnn(inputs) | ||
| } | ||
|
|
| [[ 0.20066944, 0.20825693, -0.11570193, -0.14060757]], | ||
| [[ 0.26505938, 0.29501802, -0.15672679, -0.1794617]], | ||
| [[ 0.31350702, 0.37243342, -0.1890606, -0.20662251]]]) | ||
|
|
| let x = Tensor<Float>(rangeFrom: 0.0, to: 0.4, stride: 0.1).rankLifted() | ||
| let inputs: [Tensor<Float>] = Array(repeating: x, count: 4) | ||
| let rnn = RNN(LSTMCell<Float>(inputSize: 4, hiddenSize: 4, | ||
| seed: (0xFeed, 0xBeef))) |
There was a problem hiding this comment.
Move this to the end of the previous line.
| @@ -543,6 +567,7 @@ final class LayerTests: XCTestCase { | |||
| ("testRNN", testRNN), | |||
| ("testFunction", testFunction), | |||
| ("testBatchNorm", testBatchNorm), | |||
| ("testLayerNorm", testLayerNorm) | |||
| ("testLayerNorm", testLayerNorm), | |||
| ("testLSTM", testLSTM) | |||
There was a problem hiding this comment.
Place this between "testRNN" and "testFunction" like how the methods are ordered.
rxwei
approved these changes
Aug 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.