Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Add huber loss support #534

Merged
merged 12 commits into from
Nov 14, 2019
Merged

Add huber loss support #534

merged 12 commits into from
Nov 14, 2019

Conversation

jrabary
Copy link
Contributor

@jrabary jrabary commented Oct 24, 2019

This PR adds huber loss support. Used for object detection for instance.

Co-Authored-By: Anthony Platanios <[email protected]>
Copy link
Contributor

@eaplatanios eaplatanios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrabary for addressing the comments promptly!:)

Copy link
Member

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments are addressed!

If you enable "Allow edits from maintainers" on the PR, I'm happy to push edits directly.
Screen Shot 2019-11-07 at 10 14 07 AM

@dan-zheng
Copy link
Member

CI failed:

/swift-apis/Sources/TensorFlow/StdlibExtensions.swift:217:1: error: type 'Element' does not conform to protocol 'Differentiable'
extension Array.DifferentiableView: VectorProtocol where Element: VectorProtocol {
^
/swift-apis/Sources/TensorFlow/StdlibExtensions.swift:217:1: error: 'VectorProtocol' requires that 'Element' conform to 'Differentiable'
extension Array.DifferentiableView: VectorProtocol where Element: VectorProtocol {
^
/swift-apis/Sources/TensorFlow/StdlibExtensions.swift:217:1: note: requirement specified as 'Element' : 'Differentiable'
extension Array.DifferentiableView: VectorProtocol where Element: VectorProtocol {
^
/swift-apis/Sources/TensorFlow/StdlibExtensions.swift:217:1: note: requirement from conditional conformance of 'Array<Element>.DifferentiableView' to 'AdditiveArithmetic'
extension Array.DifferentiableView: VectorProtocol where Element: VectorProtocol {
...

Could you please trying merging from master? I believe that should fix the errors.

Copy link
Member

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dan-zheng dan-zheng merged commit 8f06bee into tensorflow:master Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants