This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Extract conv1D functionality from Conv1D Layer #549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #528, the layer
Conv1D
is doing two things at a time (1) calculating a one-dimensional convolution and (2) applying the activation function. If we split this functionality into two, we enable clients to only use the conv1D. This will allow them to write code that is easier to read.Solution
Extract the
conv1D
functionality intoNN.swfit