This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Move TensorHandle related code out of ShapedArray. #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgogul
approved these changes
Nov 16, 2019
pschuh
force-pushed
the
shaped-array-handle-free
branch
from
620cea6 to
19875a0
Compare
asuhan
approved these changes
Nov 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples ShapedArray from TensorHandle and allows for alternative implementations. The current implementation uses an enum to specify the backing storage. Switching to virtual dispatch allows moving all the TensorHandle related logic to a separate file.