Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Remove TensorProtocol. #559

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Remove TensorProtocol. #559

merged 1 commit into from
Nov 16, 2019

Conversation

pschuh
Copy link
Contributor

@pschuh pschuh commented Nov 16, 2019

Unused and introduces extra dependencies on TensorHandle.

@pschuh pschuh requested review from asuhan and bgogul November 16, 2019 00:24
bgogul
bgogul approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@bgogul bgogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only needed during the GPE days, I believe.

@dan-zheng
Copy link
Member

This was only needed during the GPE days, I believe.

TensorProtocol was originally introduced as a unifying protocol when we had statically-ranked Tensor{X}D types in addition to the unranked Tensor type. We tried to generically define tensor operations on TensorProtocol, but in practice this led to ambiguity errors for the operations.

TensorProtocol became obsolete when we deleted the Tensor{X}D types!

@pschuh pschuh merged commit 83a4ef9 into tensorflow:master Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asuhan asuhan asuhan approved these changes

@saeta saeta saeta approved these changes

@bgogul bgogul bgogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pschuh @dan-zheng @asuhan @saeta @bgogul