This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Remove @differentiable attribute from Layer.inferring(from:).
#575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary for TF-835: lowering `@derivative` attribute directly to SIL differentiability witnesses instead of creating implicit `@differentiable` attributes. `@differentiable` + `@derivative` attributes for the same original declaration with the same wrt parameters will be diagnosed. To lift this limitation, derivative generic signature mangling (TF-680) is necessary to avoid name collisions for SIL derivative functions with the same parameter indices but different derivative generic signatures.
marcrasi
approved these changes
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for TF-835: lowering
@derivativeattribute directly to SILdifferentiability witnesses instead of creating implicit
@differentiableattributes.
@differentiable+@derivativeattributes for the same original declarationwith the same wrt parameters will be diagnosed:
This is already done for
@differentiable+@differentiableand@derivative+@derivativecombinations. Derivative generic signaturemangling is necessary to lift this limitation: .
To relax this limitation, derivative generic signature mangling (TF-680) is
necessary to avoid name collisions for SIL derivative functions with the same
parameter indices but different derivative generic signatures.