Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Generate Raw ops from Tensorflow2.1.0rc1 #621

Merged
merged 8 commits into from
Jan 14, 2020

Conversation

Shashi456
Copy link
Contributor

@Shashi456 Shashi456 commented Jan 14, 2020

Fixes: #619
Execute has to be overloaded up to 14 variables due to the existence of parseSequenceExampleV2.

Updated generatewrappers.swift TensorFlow import command.

High-arity return statement functions in RawOpsGenerated.swift have to be broken down by using let variables.

The accuracy of svd had to be changed for the tests to pass.

Build and test passes.

@Shashi456
Copy link
Contributor Author

@dan-zheng is build time on kokoro really on the order of 30 minutes and more?

@dan-zheng
Copy link
Member

@dan-zheng is build time on kokoro really on the order of 30 minutes and more?

Could be. CI tests more than just tensorflow/swift-apis, also tensorflow/swift-models and other related repositories to ensure they're not broken.

@Shashi456
Copy link
Contributor Author

Shashi456 commented Jan 14, 2020

@dan-zheng Changed the error bound and checked locally, the tests pass. i think this can be merged now

We should probably also change the commit hash in the tensorflow branch, since this is an api update?

@dan-zheng
Copy link
Member

dan-zheng commented Jan 14, 2020

We should probably also change the commit hash in the tensorflow branch, since this is an api update?

Yep, feel free to submit a PR to apple/swift. Here's an example: swiftlang/swift#28934

You'll want to wait until this PR is merged, though, to use the squashed+merged commit hash.

@dan-zheng dan-zheng requested a review from pschuh January 14, 2020 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regenerate RawOpsGenerated.swift
3 participants