Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Fix argument documentation #654

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Fix argument documentation #654

merged 4 commits into from
Jan 30, 2020

Conversation

sgugger
Copy link
Contributor

@sgugger sgugger commented Jan 29, 2020

This decay is not weight decay, so should be renamed to not be confusing.

This decay is not weight decay, so should be renamed to not be confusing.
@sgugger sgugger requested a review from dan-zheng January 29, 2020 22:53
Copy link
Member

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@sgugger
Copy link
Contributor Author

sgugger commented Jan 30, 2020

Also changed the precondition failure messages.

@sgugger sgugger merged commit 7e2212e into master Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants