This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Make derivatives of public functions be @usableFromInline.
#929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
force-pushed
the
derivative-same-access-level
branch
from
ec16b6c to
adae0d5
Compare
|
I built a toolchain from swiftlang/swift#31527 (requiring same original/derivative access levels), and confirmed that tensorflow/swift-apis builds after this patch. tensorflow/swift-models builds without any patches. |
marcrasi
approved these changes
May 5, 2020
|
It's fine to merge this patch now before swiftlang/swift#31527 lands. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friend PR: swiftlang/swift#31527