Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

Remove deprecated comments +@noDerivative #135

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

jekbradbury
Copy link
Contributor

Comments no longer apply (AD bug has been fixed and arrays now conform to Differentiable)

Comments no longer apply (AD bug has been fixed and arrays now conform to `Differentiable`)
@jekbradbury jekbradbury requested a review from rxwei April 29, 2019 01:57
@rxwei
Copy link
Contributor

rxwei commented Apr 29, 2019

I think that we can use differentiableReduce(_:_:) in call(_:) and remove the custom VJP now!

@rxwei rxwei merged commit 5105486 into master Apr 29, 2019
@dan-zheng dan-zheng deleted the jekbradbury-patch-1 branch April 29, 2019 17:48
pschuh pushed a commit to pschuh/swift-models that referenced this pull request Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants