This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Fix up models so they can run. #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the migration to a single SwiftPM-based package for the models repository, the working directory where people run `swift run` has changed. As a result, a number of relative-path lookups were broken when actually running models. This commit fixes them up so they all properly run.
rxwei
approved these changes
Apr 30, 2019
pschuh
pushed a commit
to pschuh/swift-models
that referenced
this pull request
Jul 30, 2019
The `matmul` op now matches the behavior of the Python op (i.e., using `batchMatmul` whenever appropriate, and it also supports transposing either or both of its arguments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the migration to a single SwiftPM-based package for the models
repository, the working directory where people run
swift runhas changed.As a result, a number of relative-path lookups were broken when actually
running models. This commit fixes them up so they all properly run.