This repository was archived by the owner on Apr 23, 2025. It is now read-only.
work around duplicate definition of diff witness #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How much work would be required to actually fix the underlying issue? Alternately, can you file a follow-up task for TF-1025 to revert this change? |
|
I will look at TF-1025 soon because this will confuse anyone who runs into it. There is some related cleanup that I would like to finish first that should make the underlying issue much easier to figure out and fix, so it might be a day before I actually create a fix. I have added a note in TF-1025 to revert this. |
BradLarson
approved these changes
Dec 2, 2019
marcrasi
pushed a commit
that referenced
this pull request
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around https://bugs.swift.org/browse/TF-1025 by specifying explicit activations on all the layers with default activations.