Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

Add DCGAN #261

Merged
merged 10 commits into from
Jan 2, 2020
Merged

Add DCGAN #261

merged 10 commits into from
Jan 2, 2020

Conversation

rickwierenga
Copy link
Contributor

Ayush Agrawal recommended me to add my DCGAN model to this repository. It currently fails to run on master due to the rapid changes in the APIs, but it does work on tensorflow-0.6 as you can see in this colab. Should I create another PR for tensorflow-0.6?

@F20170604
Copy link

@BradLarson Like you mentioned, it might make sense to group the non-convolutional GAN currently present with this DCGAN implementation somehow.
Maybe we can merge both models in one script, run them both separately with names '"GAN", "DCGAN and present graphs and images as outputs. Will this work?

@BradLarson
Copy link
Contributor

Thanks for converting your tutorial into a standalone model. Let's try to see if we can get this building against master, which shouldn't be too bad. We haven't deviated very far from the 0.6 release just yet.

As a first few comments, if you can get swift-format up and running on your system, I'd recommend running that against the files here to make sure they fit our formatting guidelines. At a glance, I see several long lines that might need to be reformatted. Additionally, we prefer capitalization and punctuation in comments, and you can look at other models in the repository for examples of how those tend to be formatted.

Beyond that, it would be really nice if we didn't have to depend on Matplotlib for image rendering. Would it be possible to use the project's image-handling functions and types instead, to write out the resulting images to disk? This is done in the existing Autoencoder and GAN examples, for example.

Regarding organization, we might be able to group the Autoencoder, GAN, and DCGAN examples together somehow, possibly placing them under Examples, but that could come after this is made operational in master.

@rickwierenga
Copy link
Contributor Author

rickwierenga commented Dec 17, 2019

So here's the ToDo list:

  • format nicely
    • comments
  • remove matplotlib (look at current GAN)

Is it ok with you if I do this tomorrow?


I think it'd be great to use jupyter notebooks for the examples, because that's what most people will be using for machine learning anyways. We could add instructions for NotebookExport so that those who want can still run models as a package.

@rickwierenga
Copy link
Contributor Author

All things are done and it runs correctly on my Mac (haven't tested it on Linux).

Let me know if there's anything else you want to see changed.

@rickwierenga
Copy link
Contributor Author

Any update on this? Happy 2020!

@BradLarson BradLarson merged commit b8db179 into tensorflow:master Jan 2, 2020
@BradLarson
Copy link
Contributor

Sorry about the delay, I'd fired off the CI check and forgot to check the results. Thanks for the work in implementing this.

@rickwierenga
Copy link
Contributor Author

Thanks!

@rickwierenga
Copy link
Contributor Author

The images aren't displaying correctly in the README. I made a fix in #268. Sorry about that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants