Skip to content

Update more.rst #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2018
Merged

Update more.rst #546

merged 9 commits into from
May 14, 2018

Conversation

2wins
Copy link
Contributor

@2wins 2wins commented May 5, 2018

Update the URLs

Checklist

  • I've tested that my changes are compatible with the latest version of Tensorflow.
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Wrong or old links

Description

Update URLs

Update the URLs
@DEKHTIARJonathan DEKHTIARJonathan self-requested a review May 5, 2018 15:58
Copy link
Member

@DEKHTIARJonathan DEKHTIARJonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your modifications. The documentation is not building anymore.

@2wins
Copy link
Contributor Author

2wins commented May 5, 2018

@DEKHTIARJonathan Do you mean that the FAQ page is no longer updated?

@DEKHTIARJonathan
Copy link
Member

Look at Travis or launch PyTest.
You will see the documentation is failing

@2wins
Copy link
Contributor Author

2wins commented May 7, 2018

@DEKHTIARJonathan it has passed PyTest. Please merge it. Thank you.

@2wins 2wins closed this May 14, 2018
@2wins 2wins deleted the patch-2 branch May 14, 2018 06:37
@2wins 2wins restored the patch-2 branch May 14, 2018 07:39
@2wins 2wins reopened this May 14, 2018
@2wins
Copy link
Contributor Author

2wins commented May 14, 2018

@DEKHTIARJonathan It's my mistake. Please check and merge it.

@DEKHTIARJonathan DEKHTIARJonathan dismissed their stale review May 14, 2018 07:53

Not comptetent to review RST

@DEKHTIARJonathan
Copy link
Member

@zsdonghao can you please have a look and merge if it looks good.
I'm not very good in RST, I don't want to make any mistake ;)

@zsdonghao zsdonghao merged commit 94414d4 into tensorlayer:master May 14, 2018
luomai pushed a commit that referenced this pull request Nov 21, 2018
* Update more.rst

Update the URLs

* Update more.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants