Skip to content

[WIP] Include Danger in travis-ci #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 13, 2018
Merged

[WIP] Include Danger in travis-ci #563

merged 10 commits into from
May 13, 2018

Conversation

lgarithm
Copy link
Member

@lgarithm lgarithm commented May 11, 2018

Checklist

  • I've tested that my changes are compatible with the latest version of Tensorflow.
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

#562

@lgarithm
Copy link
Member Author

Let's see how it works for a PR.

@lgarithm
Copy link
Member Author

Looks like it's working.

And according to our settings, failed to pass danger check won't block merge.
screen shot 2018-05-11 at 11 43 27 pm

@lgarithm
Copy link
Member Author

The remaining thing TODO is just introduce the CHANGELOG.md file,
and rewrite Dangerfile appropriately.

@lgarithm
Copy link
Member Author

@luomai the danger check provides a way of running additional checks within travis-ci.
We were searching for such a solution (a way to add warning message in test, but not fail to test.) when fixing pylints.

@DEKHTIARJonathan
Copy link
Member

@lgarithm I have added a template for the Changelog.md

I will update it with the relevant information for the 1.8.5 release

@tensorlayer tensorlayer deleted a comment from lgarithm May 11, 2018
@tensorlayer tensorlayer deleted a comment from lgarithm May 11, 2018
@tensorlayer tensorlayer deleted a comment from lgarithm May 11, 2018
@DEKHTIARJonathan DEKHTIARJonathan changed the title include Danger in travis-ci [WIP] Include Danger in travis-ci May 11, 2018
@tensorlayer tensorlayer deleted a comment from lgarithm May 11, 2018
@tensorlayer tensorlayer deleted a comment from lgarithm May 11, 2018
@lgarithm
Copy link
Member Author

1 Error
🚫 Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.
1 Message
📖 Note, we hard-wrap at 80 chars and use 2 spaces after the last line.

Generated by 🚫 Danger

@DEKHTIARJonathan
Copy link
Member

DEKHTIARJonathan commented May 11, 2018

@zsdonghao @lgarithm we should try a merge. It seems that we need to have the Changelog inside the repository for it to work.

Is it fine if I merge and we'll see if it works ? We can still rollback if it doesn't.

I have modified in the PR :

  • Danger will only run with Python 3.6 on pull requests.
  • I have added a template Changelog
  • Added a few custom configs to danger i found in various places.

@DEKHTIARJonathan
Copy link
Member

After a talk with @zsdonghao I merge this PR

@DEKHTIARJonathan DEKHTIARJonathan merged commit 1d539ab into master May 13, 2018
@2wins
Copy link
Contributor

2wins commented May 13, 2018

@DEKHTIARJonathan This PR seems to have a problem. Any PR cannot pass the Travis-CI test now.

@DEKHTIARJonathan
Copy link
Member

Problem with API key I'll fix it tonight. I don't have my computer now

@lgarithm lgarithm deleted the danger branch May 13, 2018 14:45
luomai pushed a commit that referenced this pull request Nov 21, 2018
[WIP] Include Danger in travis-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants