-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[WIP] Include Danger in travis-ci #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let's see how it works for a PR. |
The remaining thing TODO is just introduce the CHANGELOG.md file, |
@luomai the danger check provides a way of running additional checks within travis-ci. |
@lgarithm I have added a template for the Changelog.md I will update it with the relevant information for the 1.8.5 release |
Generated by 🚫 Danger |
@zsdonghao @lgarithm we should try a merge. It seems that we need to have the Changelog inside the repository for it to work. Is it fine if I merge and we'll see if it works ? We can still rollback if it doesn't. I have modified in the PR :
|
After a talk with @zsdonghao I merge this PR |
@DEKHTIARJonathan This PR seems to have a problem. Any PR cannot pass the Travis-CI test now. |
Problem with API key I'll fix it tonight. I don't have my computer now |
[WIP] Include Danger in travis-ci
Checklist
Motivation and Context
#562