Skip to content

Affine transformation APIs for high-performance image augmentation #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Oct 14, 2018

Conversation

zsdonghao
Copy link
Member

Checklist

  • I've tested that my changes are compatible with the latest version of Tensorflow.
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Support Fast Affine Transformation

@zsdonghao zsdonghao changed the title release affine transform matrix APIs [WIP] release affine transform matrix APIs Sep 29, 2018
@zsdonghao zsdonghao requested a review from luomai September 29, 2018 23:11
@zsdonghao
Copy link
Member Author

zsdonghao commented Sep 29, 2018

@luomai please write the docs, and also the dataset prefetch order of existing examples.

@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@tensorlayer tensorlayer deleted a comment Sep 30, 2018
Copy link
Member

@DEKHTIARJonathan DEKHTIARJonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge, explanation below.

After some discussion with @zsdonghao, we stated that only bug fixes and dependency updates will be merged. This is done to ease transition toward TL 2.0. We need to keep an easy and clean codebase with the change upcoming both with TL 2.0 and TF 2.0. Every-time big changes are performed, additional work is required to reflect the changes in the PR #755, in particular if those changes impact the layers module.

You can still update this PR as your wishes. It will be merged as soon as possible once we have cleared the backlog.

If you need this PR to work, you can manually build this PR and install it locally ;) Sorry for the inconvenience.

Thanks for your understanding and the work ;) We'll get back to you as soon as we are ready to merge.

@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@luomai
Copy link
Member

luomai commented Sep 30, 2018

@DEKHTIARJonathan Hey John, this PR would not touch any layer. It only affect tl.prepro.

@zsdonghao
Copy link
Member Author

@DEKHTIARJonathan this PR would not affect the layer APIs, and we really need it for the openpose project.

@tensorlayer tensorlayer deleted a comment Sep 30, 2018
@tensorlayer tensorlayer deleted a comment Oct 13, 2018
@tensorlayer tensorlayer deleted a comment Oct 13, 2018
@tensorlayer tensorlayer deleted a comment Oct 13, 2018
@tensorlayer tensorlayer deleted a comment Oct 13, 2018
@tensorlayer tensorlayer deleted a comment Oct 13, 2018
@tensorlayer tensorlayer deleted a comment Oct 13, 2018
@tensorlayer tensorlayer deleted a comment Oct 13, 2018
@tensorlayer tensorlayer deleted a comment Oct 13, 2018
@tensorlayer tensorlayer deleted a comment Oct 14, 2018
@tensorlayer tensorlayer deleted a comment Oct 14, 2018
@DEKHTIARJonathan DEKHTIARJonathan dismissed their stale review October 14, 2018 07:23

Merge possible without work

@DEKHTIARJonathan
Copy link
Member

DEKHTIARJonathan commented Oct 14, 2018

@zsdonghao @lgarithm if you want to want to merge this PR, LGTM.
Thanks to @luomai, the merge commit it already done in TL 2.0

Before merging please fix these issues: https://app.codacy.com/app/zsdonghao/tensorlayer/pullRequest?prid=2273850

lgarithm
lgarithm previously approved these changes Oct 14, 2018
@lgarithm lgarithm dismissed their stale review October 14, 2018 09:46

fixing codacy

@tensorlayer tensorlayer deleted a comment Oct 14, 2018
@tensorlayer tensorlayer deleted a comment Oct 14, 2018
@luomai luomai merged commit 27d7962 into master Oct 14, 2018
@luomai luomai deleted the affine-transform branch October 14, 2018 10:19
luomai pushed a commit that referenced this pull request Nov 21, 2018
)

* release affine transform matrix APIs

* chaneglog

* affine transform example

* example with dataset API;

* rm unused import

* update docs

* x

* remove pickle

* shear v2

* x

* respective zoom

* Add text

* minor fix

* x

* x

* cv2

* remove random

* woring on cv2

* cv2 transform done

* Keypoints done

* test and clean up tutorial and doc.

* add vertical flipping.

* docs

* fix

* imporve doc

* fix

* fix

* tune figure positions.

* :scale: -> :width:

* change pdf to png

* use jpeg

* fix alignment

* update doc

* fix doc

* resize then random crop

* fix docs

* try fix doc indent (#864)

doc test fix

* update CHANGELOG

* Update CHANGELOG.md

* fix lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants