Skip to content

docs: Update README Usage section to reflect array format for identity_sources #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bigdragon0610
Copy link
Contributor

@bigdragon0610 bigdragon0610 commented Jul 11, 2024

Description

  • Changed identity_sources in authorizers from a string to an array of strings in the Usage section.

Motivation and Context

In the README file, the identity_sources field in the authorizers section of the Usage example was incorrectly listed as a string.
According to the module's specifications, identity_sources should be an array of strings.

Here is an image of the error encountered with the current documentation:
screenshot 2024-07-11 19 24 29

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

…y_sources

- Changed `identity_sources` in `authorizers` from a string to an array of strings in the Usage section.
@bryantbiggs bryantbiggs merged commit bfb473d into terraform-aws-modules:master Jul 11, 2024
10 checks passed
@antonbabenko
Copy link
Member

This PR is included in version 5.1.1 🎉

Copy link

github-actions bot commented Sep 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants