Skip to content

docs: Add redirect link for Block Devices #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

lanandra
Copy link
Contributor

@lanandra lanandra commented Oct 1, 2024

Description

Add redirect link for Block Devices configuration block details

Motivation and Context

Previously the description stated as below

Customize details about the root block device of the instance. See Block Devices below for details

I checked in the README there is no information details regarding Block Devices thus this will make word below misleading. As a solution, propose to change that with redirect link to AWS provider documentation section Block Devices in resource aws_instance

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@lanandra lanandra changed the title docs: add redirect link for Block Devices docs: Add redirect link for Block Devices Oct 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 1, 2024
@lanandra
Copy link
Contributor Author

lanandra commented Nov 1, 2024

@antonbabenko can you please check about this proposal ? what your thoughts about this ? is this something valuable and we need or not

@github-actions github-actions bot removed the stale label Nov 2, 2024
@bryantbiggs bryantbiggs merged commit 6f851d8 into terraform-aws-modules:master Nov 2, 2024
2 of 3 checks passed
Copy link

github-actions bot commented Dec 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
@antonbabenko
Copy link
Member

This PR is included in version 5.8.0 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants