-
-
Notifications
You must be signed in to change notification settings - Fork 23
feat: Allow passing in custom instance profile role #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow passing in custom instance profile role #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comment/update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... @bryantbiggs WDYT?
## [2.3.0](v2.2.0...v2.3.0) (2024-09-21) ### Features * Allow passing in custom instance profile role ([#30](#30)) ([0712293](0712293))
This PR is included in version 2.3.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Allows passing in a custom instance profile role and custom autoscaling role to the service pass role policy.
Also includes minor provider version upgrade hashicorp/terraform-provider-aws#37740.
Motivation and Context
Closes: #26
Breaking Changes
No.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request