Skip to content

feat: Allow passing in custom instance profile role #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Sep 13, 2024

Description

Allows passing in a custom instance profile role and custom autoscaling role to the service pass role policy.
Also includes minor provider version upgrade hashicorp/terraform-provider-aws#37740.

Motivation and Context

Closes: #26

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment/update

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... @bryantbiggs WDYT?

@bryantbiggs bryantbiggs merged commit 0712293 into terraform-aws-modules:master Sep 21, 2024
13 checks passed
antonbabenko pushed a commit that referenced this pull request Sep 21, 2024
## [2.3.0](v2.2.0...v2.3.0) (2024-09-21)

### Features

* Allow passing in custom instance profile role ([#30](#30)) ([0712293](0712293))
@antonbabenko
Copy link
Member

This PR is included in version 2.3.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Pass Role does not support custom instance profile
3 participants