feat: Explicitly grant elasticloadbalancing:AddTags permission
#382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per AWS customer notifications, the elasticloadbalancing:AddTags permission will be required soon for anyone calling CreateLoadBalancer with tags: > On June 1, 2023, we will be adding an additional layer of security to > ELB ‘Create*' API calls where API callers must have explicit access to > add tags in their Identity and Access Management (IAM) policy [1]. > Currently, access to attach tags was implicitly granted with access to > 'Create*' APIs. … We will be allowing 'Create*' API calls with the > current policy to be accepted until August 30, 2023. After this date, > the 'Create*' API call will fail and return an error if the the > attribute is specified and permission is not granted.
acdha
force-pushed
the
add-elb-tag-permission
branch
from
7fbe7ec to
151a60c
Compare
acdha
changed the title
bryantbiggs
changed the title
elasticloadbalancing:AddTags permission along with Create*
bryantbiggs
changed the title
elasticloadbalancing:AddTags permission along with Create*elasticloadbalancing:AddTags permission
bryantbiggs
approved these changes
May 24, 2023
|
This PR is included in version 5.21.0 🎉 |
|
I don't think this is the equivalent of the current upstream policy but the translation to HCL makes it a little hard to follow. The diff between v2.4.3 and v2.5.3 is this statement block: + {
+ "Effect": "Allow",
+ "Action": [
+ "elasticloadbalancing:AddTags"
+ ],
+ "Resource": [
+ "arn:aws:elasticloadbalancing:*:*:targetgroup/*/*",
+ "arn:aws:elasticloadbalancing:*:*:loadbalancer/net/*/*",
+ "arn:aws:elasticloadbalancing:*:*:loadbalancer/app/*/*"
+ ],
+ "Condition": {
+ "StringEquals": {
+ "elasticloadbalancing:CreateAction": [
+ "CreateTargetGroup",
+ "CreateLoadBalancer"
+ ]
+ },
+ "Null": {
+ "aws:RequestTag/elbv2.k8s.aws/cluster": "false"
+ }
+ }
+ },which appears to already be in the existing policy having been added in e1403c1 in #358. Would it make more sense to instead use the raw JSON from upstream here to make it much easier to maintain this and show the direct link to upstream? |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per AWS customer notifications, the
elasticloadbalancing:AddTagspermission will be required soon for anyone callingCreateLoadBalancerwith tags: