feat: AWS Instance Scheduler Tagging Support #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-wiggins
changed the title
andrew-wiggins
changed the title
bryantbiggs
reviewed
Mar 6, 2021
variables.tf
Outdated
| @@ -280,6 +280,12 @@ variable "tags" { | |||
| default = {} | |||
| } | |||
|
|
|||
| variable "cluster_specific_tags" { | |||
There was a problem hiding this comment.
can we call this cluster_tags please
bryantbiggs
approved these changes
Mar 8, 2021
|
Thanks, v3.8.0 has been just released. |
lsc
added a commit
to qapital/terraform-aws-rds-aurora
that referenced
this pull request
Apr 27, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new input variable for the module that allows tags to be applied to the RDS cluster only. Existing functionality with the current tags variable is preserved by using a merge of the two maps.
Motivation and Context
Motivation for adding this new input is that the AWS Instance Scheduler requires tags be added to the RDS cluster only for it to work (i.e. there cannot be a schedule tag added to the RDS instance). Therefore this change is being introduced to allow some tags to specifically be added to the cluster.
Breaking Changes
No breaking changes. This only introduces one new input variable and merges it into the existing tags on the RDS cluster.
How Has This Been Tested?
This change has been tested in development and staging environments and works as expected. AWS Instance Scheduler picks up these tagged clusters and starts/stops them as needed.